Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
microsoft-github-policy-service
bot
added
the
Compute
naga-nandyala
changed the title
naga-nandyala
changed the title
naga-nandyala
changed the title
naga-nandyala
force-pushed
the
naga/vm_gallery_warning_32376
branch
from
0ade229 to
7d84fac
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds breaking change warnings for Azure Compute Gallery image version commands to notify users about upcoming default value changes in API version 2026-03-03.
- Registers two new default value breaking changes for
sig image-version createcommand - Imports
register_other_breaking_changefunction (though not actively used) - Includes commented-out alternative implementations using
register_other_breaking_change
Comments suppressed due to low confidence (2)
src/azure-cli/azure/cli/command_modules/vm/_breaking_change.py:5
- The import
register_other_breaking_changeis never used since all calls to it are commented out. Remove this unused import to keep the code clean.
from azure.cli.core.breaking_change import register_default_value_breaking_change
src/azure-cli/azure/cli/command_modules/vm/_breaking_change.py:46
- Remove the commented-out code blocks. If these alternative implementations using
register_other_breaking_changeare not needed, they should be deleted rather than left commented out. If they might be needed in the future, consider documenting the reasoning with a single-line comment or tracking through a separate issue. Large blocks of commented code reduce code maintainability.
register_default_value_breaking_change(command_name='sig image-version update',
arg='--end-of-life-date',
current_default=None,
new_default='6 months from publish date',
target_version=None)
register_default_value_breaking_change(command_name='sig image-version update',
arg='--block-deletion-before-end-of-life',
current_default=None,
new_default=True,
target_version=None)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+19
to
+29
| register_default_value_breaking_change(command_name='sig image-version create', | ||
| arg='--end-of-life-date', | ||
| current_default=None, | ||
| new_default='6 months from publish date', | ||
| target_version=None) | ||
|
|
||
| register_default_value_breaking_change(command_name='sig image-version create', | ||
| arg='--block-deletion-before-end-of-life', | ||
| current_default=None, | ||
| new_default=True, | ||
| target_version=None) |
There was a problem hiding this comment.
The PR title mentions adding warnings for both az sig image-version create and az sig image-version update, but only the create command has breaking change registrations. Add similar register_default_value_breaking_change registrations for the update command to match the PR's stated purpose, or update the PR title/description to clarify that only create is being addressed.
Contributor
Author
There was a problem hiding this comment.
i have code for update as well
naga-nandyala
changed the title
az sig image-version create/update: Warning message for Azure Compute Gallery resources from Api-version 2026-03-03
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
changed the title
az sig image-version create/update: Warning message for Azure Compute Gallery resources from Api-version 2026-03-03az sig image-version create/update: Add warning message for Azure Compute Gallery resources from Api-version 2026-03-03
Contributor
|
since it is not an actual breaking change but just a pre-announcement, I've refined the title accordingly. |
yanzhudd
approved these changes
Jan 4, 2026
yanzhudd
changed the title
az sig image-version create/update: Add warning message for Azure Compute Gallery resources from Api-version 2026-03-03az sig image-version create/update: Add warning message for Azure Compute Gallery resources from api-version 2026-03-03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az sig image-version create
az sig image-version update
Description
close: #32376
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.